ECEF fields require integer parsing of twos compliment numbers.#6
Open
torriem wants to merge 2 commits intojcmb:masterfrom
Open
ECEF fields require integer parsing of twos compliment numbers.#6torriem wants to merge 2 commits intojcmb:masterfrom
torriem wants to merge 2 commits intojcmb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer parsing did not properly handle negative numbers, thus ECEF values decoded from message types 1005 and 1006 were incorrect. This patch adds the proper parsing of signed integer values. RTCM integer fields are stored in big-ending, twos-complement notation. To parse them, if the MSB is 1, then we need to XOR all the bits, add 1, and then add the negative sign.